From 3cad0d4438ba54e407dbe6a4c306700e3ef1ffd6 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Fri, 7 Feb 2025 17:28:20 +0000 Subject: [PATCH] Try passing `WINDOWS_SIGN_WITH_PARAMS` manually Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- .github/workflows/build_windows.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml index 9740ed23..864080c3 100644 --- a/.github/workflows/build_windows.yaml +++ b/.github/workflows/build_windows.yaml @@ -36,7 +36,7 @@ jobs: env: SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.22000.0/x86/signtool.exe" # electron-windows-sign of electron-winstaller uses a different env var - #WINDOWS_SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.22000.0/x86/signtool.exe" + WINDOWS_SIGNTOOL_PATH: "C:/Program Files (x86)/Windows Kits/10/bin/10.0.22000.0/x86/signtool.exe" DEBUG: electron-builder steps: - uses: nbucic/variable-mapper@0673f6891a0619ba7c002ecfed0f9f4f39017b6f @@ -152,6 +152,7 @@ jobs: echo "ED_SIGNTOOL_THUMBPRINT=$Thumbprint" >> $env:GITHUB_ENV echo "ED_SIGNTOOL_SUBJECT_NAME=$SubjectName" >> $env:GITHUB_ENV + echo "WINDOWS_SIGN_WITH_PARAMS=/sha1 $Thumbprint" >> $env:GITHUB_ENV env: ESIGNER_URL: https://github.com/SSLcom/eSignerCKA/releases/download/v1.0.6/SSL.COM-eSigner-CKA_1.0.6.zip INSTALL_DIR: C:\Users\runneradmin\eSignerCKA