diff --git a/.github/workflows/build_linux.yaml b/.github/workflows/build_linux.yaml index dd0b894f..1c3dd797 100644 --- a/.github/workflows/build_linux.yaml +++ b/.github/workflows/build_linux.yaml @@ -123,11 +123,6 @@ jobs: ./scripts/glibc-check.sh $filename done - - name: "[Nightly] Resolve version" - if: inputs.version != '' - run: | - echo "ED_NIGHTLY=${{ inputs.version }}" >> $GITHUB_ENV - - name: Generate debian files and arguments run: | if [ -f changelog.Debian ]; then @@ -144,6 +139,9 @@ jobs: - name: Build App run: yarn build --publish never -l ${{ steps.config.outputs.build-args }} + env: + # Only set for Nightly builds + ED_NIGHTLY: ${{ inputs.version }} - name: Check native libraries run: | diff --git a/.github/workflows/build_macos.yaml b/.github/workflows/build_macos.yaml index b1b423eb..44fa4a1d 100644 --- a/.github/workflows/build_macos.yaml +++ b/.github/workflows/build_macos.yaml @@ -65,7 +65,6 @@ jobs: node-version-file: package.json cache: "yarn" - # Does not need branch matching as only analyses this layer - name: Install Deps run: "yarn install --frozen-lockfile" @@ -76,11 +75,6 @@ jobs: pip3 install setuptools yarn build:native:universal - - name: "[Nightly] Resolve version" - if: inputs.version != '' - run: | - echo "ED_NIGHTLY=${{ inputs.version }}" >> $GITHUB_ENV - # We split these because electron-builder gets upset if we set CSC_LINK even to an empty string - name: "[Signed] Build App" if: inputs.sign != '' @@ -107,6 +101,8 @@ jobs: yarn build:universal --publish never env: CSC_IDENTITY_AUTO_DISCOVERY: false + # Only set for Nightly builds + ED_NIGHTLY: ${{ inputs.version }} - name: Generate releases.json if: inputs.base-url diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml index 1802beff..a553027d 100644 --- a/.github/workflows/build_windows.yaml +++ b/.github/workflows/build_windows.yaml @@ -107,7 +107,6 @@ jobs: node-version-file: package.json cache: "yarn" - # Does not need branch matching as only analyses this layer - name: Install Deps run: "yarn install --frozen-lockfile" @@ -160,19 +159,11 @@ jobs: INSTALL_DIR: C:\Users\runneradmin\eSignerCKA MASTER_KEY_FILE: C:\Users\runneradmin\eSignerCKA\master.key - - name: "[Nightly] Resolve version" - if: inputs.version != '' - shell: bash - run: | - echo "ED_NIGHTLY=${{ inputs.version }}" >> $GITHUB_ENV - - # XXX: For whatever reason if we use `yarn build ...` it freezes, but splitting it into parts it is fine - - run: yarn run build:ts - - run: yarn run build:res - - name: Build App - run: | - yarn electron-builder --publish never -w ${{ steps.config.outputs.build-args }} + run: yarn build --publish never -w ${{ steps.config.outputs.build-args }} + env: + # Only set for Nightly builds + ED_NIGHTLY: ${{ inputs.version }} - name: Check app was signed successfully if: inputs.sign