CringeStudios/gamja
5
0
Fork 1
mirror of https://codeberg.org/emersion/gamja synced 2025-03-13 07:48:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

lib/client: remove WebSocket error event handler

Browse Source 
The error event handler is useless, because the error event is never
emitted without a close event, and doesn't give any details about
the error.
This commit is contained in:
Simon Ser 2021-09-06 17:11:28 +02:00
parent ed41f08ba4
commit beef13d273
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/client.js
View File

@ -22,6 +22,11 @@ const permanentCaps = [
const RECONNECT_DELAY_SEC = 10; const RECONNECT_DELAY_SEC = 10;
// WebSocket status codes
// https://www.rfc-editor.org/rfc/rfc6455.html#section-7.4.1
const NORMAL_CLOSURE = 1000;
const GOING_AWAY = 1001;
let lastLabel = 0; let lastLabel = 0;
export default class Client extends EventTarget { export default class Client extends EventTarget {
@ -90,6 +95,10 @@ export default class Client extends EventTarget {
this.ws.addEventListener("close", (event) => { this.ws.addEventListener("close", (event) => {
console.log("Connection closed (code: " + event.code + ")"); console.log("Connection closed (code: " + event.code + ")");
if (event.code !== NORMAL_CLOSURE && event.code !== GOING_AWAY) {
this.dispatchEvent(new CustomEvent("error", { detail: "Connection error" }));
}
this.ws = null; this.ws = null;
this.setStatus(Client.Status.DISCONNECTED); this.setStatus(Client.Status.DISCONNECTED);
this.nick = null; this.nick = null;
@ -118,10 +127,6 @@ export default class Client extends EventTarget {
} }
} }
}); });
this.ws.addEventListener("error", () => {
this.dispatchEvent(new CustomEvent("error", { detail: "Connection error" }));
});
} }
disconnect() { disconnect() {