From ca0a48196c256f597c25604ff27ddf620ea6ed9b Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Mon, 23 Oct 2023 12:04:58 +0100
Subject: [PATCH] Fix Nightly builds not bailing on failure (#1289)

---
 .github/workflows/build_and_deploy.yaml | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/build_and_deploy.yaml b/.github/workflows/build_and_deploy.yaml
index b29aaa6..67f0ad6 100644
--- a/.github/workflows/build_and_deploy.yaml
+++ b/.github/workflows/build_and_deploy.yaml
@@ -120,13 +120,12 @@ jobs:
         runs-on: ubuntu-latest
         name: Deploy
         if: |
-            (
+            always() && !failure() && !cancelled() && ((
                 github.event_name != 'workflow_dispatch' &&
                 github.event.release.prerelease != true
             ) || (
-                always() && !failure() && !cancelled() && inputs.deploy &&
-                (inputs.macos || inputs.windows || inputs.linux)
-            )
+                inputs.deploy && (inputs.macos || inputs.windows || inputs.linux)
+            ))
         environment: packages.element.io
         steps:
             - name: Download artifacts
@@ -161,12 +160,12 @@ jobs:
             matrix:
                 arch: [amd64, arm64]
         if: |
-            (
+            always() && !failure() && !cancelled() && ((
                 github.event_name != 'workflow_dispatch' &&
                 github.event.release.prerelease != true
             ) || (
-                always() && !failure() && !cancelled() && inputs.deploy && inputs.linux
-            )
+                inputs.deploy && inputs.linux
+            ))
         uses: ./.github/workflows/reprepro.yaml
         secrets: inherit
         with: