From 058bb09bf4c7546fcaa0d40ba9e4540391bd6ead Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Wed, 20 Dec 2023 10:01:54 +0000
Subject: [PATCH] Revert "Upgrade to {upload,download}-artifact@v4 for better
 performance" (#1396)

---
 .github/workflows/build_and_deploy.yaml | 2 +-
 .github/workflows/build_and_test.yaml   | 6 +++---
 .github/workflows/build_linux.yaml      | 6 +++---
 .github/workflows/build_macos.yaml      | 4 ++--
 .github/workflows/build_prepare.yaml    | 2 +-
 .github/workflows/build_windows.yaml    | 4 ++--
 6 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/build_and_deploy.yaml b/.github/workflows/build_and_deploy.yaml
index 03c3313..587e311 100644
--- a/.github/workflows/build_and_deploy.yaml
+++ b/.github/workflows/build_and_deploy.yaml
@@ -127,7 +127,7 @@ jobs:
         environment: packages.element.io
         steps:
             - name: Download artifacts
-              uses: actions/download-artifact@v4
+              uses: actions/download-artifact@v3
 
             - name: Deploy artifacts
               run: |
diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml
index b1d1007..ff32507 100644
--- a/.github/workflows/build_and_test.yaml
+++ b/.github/workflows/build_and_test.yaml
@@ -138,7 +138,7 @@ jobs:
             - name: Install Deps
               run: "yarn install --frozen-lockfile"
 
-            - uses: actions/download-artifact@v4
+            - uses: actions/download-artifact@v3
               with:
                   name: ${{ matrix.artifact }}
                   path: dist
@@ -156,9 +156,9 @@ jobs:
                   ELEMENT_DESKTOP_EXECUTABLE: ${{ matrix.executable }}
 
             - name: Upload Artifacts
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v3
               if: always()
               with:
-                  name: ${{ matrix.artifact }}-test-result
+                  name: ${{ matrix.artifact }}
                   path: test_artifacts
                   retention-days: 1
diff --git a/.github/workflows/build_linux.yaml b/.github/workflows/build_linux.yaml
index b08cabc..a5bb6a1 100644
--- a/.github/workflows/build_linux.yaml
+++ b/.github/workflows/build_linux.yaml
@@ -57,7 +57,7 @@ jobs:
 
             - uses: actions/checkout@v3
 
-            - uses: actions/download-artifact@v4
+            - uses: actions/download-artifact@v3
               with:
                   name: webapp
 
@@ -150,7 +150,7 @@ jobs:
 
             - name: Stash deb package
               if: inputs.deploy-mode
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v3
               with:
                   name: linux-sqlcipher-${{ inputs.sqlcipher }}-deb
                   path: dist/*.deb
@@ -178,7 +178,7 @@ jobs:
 
             # We exclude *-unpacked as it loses permissions and the tarball contains it with correct permissions
             - name: Upload Artifacts
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v3
               with:
                   name: ${{ inputs.deploy-mode && 'packages.element.io' || format('linux-{0}-sqlcipher-{1}', inputs.arch, inputs.sqlcipher) }}
                   path: |
diff --git a/.github/workflows/build_macos.yaml b/.github/workflows/build_macos.yaml
index c9628a9..4087d53 100644
--- a/.github/workflows/build_macos.yaml
+++ b/.github/workflows/build_macos.yaml
@@ -38,7 +38,7 @@ jobs:
         steps:
             - uses: actions/checkout@v3
 
-            - uses: actions/download-artifact@v4
+            - uses: actions/download-artifact@v3
               with:
                   name: webapp
 
@@ -151,7 +151,7 @@ jobs:
 
             # We exclude mac-universal as the unpacked app takes forever to upload and zip and dmg already contain it
             - name: Upload Artifacts
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v3
               with:
                   name: ${{ inputs.deploy-mode && 'packages.element.io' || 'macos' }}
                   path: |
diff --git a/.github/workflows/build_prepare.yaml b/.github/workflows/build_prepare.yaml
index 5f2a579..eeaaf77 100644
--- a/.github/workflows/build_prepare.yaml
+++ b/.github/workflows/build_prepare.yaml
@@ -128,7 +128,7 @@ jobs:
                   echo "| React SDK   | [$REACT_VERSION](https://github.com/matrix-org/matrix-react-sdk/commit/$REACT_VERSION) |" >> $GITHUB_STEP_SUMMARY
                   echo "| JS SDK      | [$JS_VERSION](https://github.com/matrix-org/matrix-js-sdk/commit/$JS_VERSION) |" >> $GITHUB_STEP_SUMMARY
 
-            - uses: actions/upload-artifact@v4
+            - uses: actions/upload-artifact@v3
               with:
                   name: webapp
                   retention-days: 1
diff --git a/.github/workflows/build_windows.yaml b/.github/workflows/build_windows.yaml
index 2b09c14..581db44 100644
--- a/.github/workflows/build_windows.yaml
+++ b/.github/workflows/build_windows.yaml
@@ -60,7 +60,7 @@ jobs:
 
             - uses: actions/checkout@v3
 
-            - uses: actions/download-artifact@v4
+            - uses: actions/download-artifact@v3
               with:
                   name: webapp
 
@@ -197,7 +197,7 @@ jobs:
               working-directory: "dist/install/win32/${{ steps.config.outputs.dir }}"
 
             - name: Upload Artifacts
-              uses: actions/upload-artifact@v4
+              uses: actions/upload-artifact@v3
               with:
                   name: ${{ inputs.deploy-mode && 'packages.element.io' || format('win-{0}', inputs.arch) }}
                   path: dist