From ce239e5785fae79592f9a321f4b5c8f80f61028f Mon Sep 17 00:00:00 2001 From: Simon Ser Date: Fri, 28 May 2021 18:36:25 +0200 Subject: [PATCH] Improve FoldGroup key and shouldComponentUpdate --- components/buffer.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/components/buffer.js b/components/buffer.js index a91522b..6e96b7e 100644 --- a/components/buffer.js +++ b/components/buffer.js @@ -167,7 +167,8 @@ class LogLine extends Component { class FoldGroup extends Component { shouldComponentUpdate(nextProps) { - return this.props.message !== nextProps.message; + return this.props.messages[0] !== nextProps.messages[0] || + this.props.messages[this.props.messages.length - 1] !== nextProps.messages[nextProps.messages.length - 1]; } render() { @@ -337,7 +338,7 @@ export default class Buffer extends Component { } return html` <${FoldGroup} - key=${"fold-" + msgs[0].key + "-" + msgs.length} + key=${"fold-" + msgs[0].key + "-" + msgs[msgs.length - 1].key} messages=${msgs} buffer=${buf} onNickClick=${onNickClick}